Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper: convert BGP confederation config #4960

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

progwriter
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4960 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #4960      +/-   ##
============================================
+ Coverage     76.56%   76.56%   +<.01%     
  Complexity    29839    29839              
============================================
  Files          2384     2384              
  Lines        115079   115085       +6     
  Branches      13604    13605       +1     
============================================
+ Hits          88106    88112       +6     
+ Misses        20297    20294       -3     
- Partials       6676     6679       +3
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/flatjuniper/ConfigurationBuilder.java 63.35% <ø> (-0.02%) 720 <0> (ø)
...rc/main/java/org/batfish/datamodel/BgpProcess.java 89.36% <100%> (+0.23%) 32 <1> (+1) ⬆️
...h/representation/juniper/JuniperConfiguration.java 88.66% <80%> (-0.03%) 414 <0> (+1)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 84.12% <0%> (+0.12%) 510% <0%> (+1%) ⬆️

@progwriter progwriter merged commit 4cbc810 into batfish:master Oct 11, 2019
@progwriter progwriter deleted the juniper-convert-confeds branch October 11, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants