Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus: convert BGP confederation configs #4961

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

progwriter
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4961 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #4961      +/-   ##
============================================
- Coverage     76.57%   76.56%   -0.01%     
+ Complexity    29848    29841       -7     
============================================
  Files          2384     2384              
  Lines        115085   115091       +6     
  Branches      13605    13606       +1     
============================================
  Hits          88124    88124              
+ Misses        20290    20284       -6     
- Partials       6671     6683      +12
Impacted Files Coverage Δ Complexity Δ
...presentation/cumulus/CumulusNcluConfiguration.java 92.72% <83.33%> (-0.07%) 224 <0> (+1)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0%> (-2.64%) 15% <0%> (-1%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.15% <0%> (-1.52%) 63% <0%> (-2%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.67% <0%> (-0.34%) 255% <0%> (-2%)
...batfish/src/main/java/org/batfish/main/Driver.java 38.55% <0%> (+0.24%) 28% <0%> (ø) ⬇️
...a/org/batfish/job/ParseVendorConfigurationJob.java 73.93% <0%> (+3.19%) 31% <0%> (+1%) ⬆️

@progwriter progwriter merged commit 227eafe into batfish:master Oct 11, 2019
@progwriter progwriter deleted the cumulus-convert-confed branch October 11, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants