Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgesAnswerer use OspfTopology edges directly #5000

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

arifogel
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit f38c8e3 into batfish:master Oct 15, 2019
@arifogel arifogel deleted the ari-ospf-edges-use-topology branch October 15, 2019 23:10
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #5000 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #5000      +/-   ##
============================================
- Coverage     76.62%   76.61%   -0.01%     
+ Complexity    30023    30019       -4     
============================================
  Files          2399     2399              
  Lines        115658   115652       -6     
  Branches      13662    13660       -2     
============================================
- Hits          88620    88612       -8     
- Misses        20321    20327       +6     
+ Partials       6717     6713       -4
Impacted Files Coverage Δ Complexity Δ
.../java/org/batfish/datamodel/ospf/OspfTopology.java 93.93% <ø> (ø) 22 <0> (ø) ⬇️
...java/org/batfish/question/edges/EdgesAnswerer.java 82.6% <83.33%> (-0.73%) 44 <2> (-5)
...batfish/src/main/java/org/batfish/main/Driver.java 38.3% <0%> (-0.25%) 28% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 83.98% <0%> (-0.13%) 509% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 65.16% <0%> (+1.12%) 16% <0%> (+1%) ⬆️
...org/batfish/datamodel/flow/BidirectionalTrace.java 84.09% <0%> (+2.27%) 15% <0%> (+1%) ⬆️
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 38.88% <0%> (+5.55%) 5% <0%> (+1%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants