Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract redistributed connected routes in bgp; convert to vi #5001

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

yifeiyuan
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@yifeiyuan yifeiyuan merged commit 89caee1 into master Oct 15, 2019
@yifeiyuan yifeiyuan deleted the yifei-f5-bgp-redistributed-connected-conversion branch October 15, 2019 23:57
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #5001 into master will increase coverage by <.01%.
The diff coverage is 96.55%.

@@             Coverage Diff              @@
##             master    #5001      +/-   ##
============================================
+ Coverage     76.62%   76.62%   +<.01%     
+ Complexity    30025    30022       -3     
============================================
  Files          2399     2399              
  Lines        115658   115680      +22     
  Branches      13662    13664       +2     
============================================
+ Hits          88622    88642      +20     
- Misses        20325    20326       +1     
- Partials       6711     6712       +1
Impacted Files Coverage Δ Complexity Δ
..._bigip_imish/F5BigipImishConfigurationBuilder.java 91.47% <100%> (+0.22%) 91 <2> (+1) ⬆️
...epresentation/f5_bigip/F5BigipRoutingProtocol.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...representation/f5_bigip/F5BigipStructureUsage.java 100% <100%> (ø) 3 <0> (ø) ⬇️
.../representation/f5_bigip/F5BigipConfiguration.java 93.48% <94.11%> (+0.01%) 259 <0> (+2) ⬆️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...java/org/batfish/question/edges/EdgesAnswerer.java 82.6% <0%> (-0.73%) 44% <0%> (-5%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.25% <0%> (-0.39%) 64% <0%> (-1%)
.../java/org/batfish/datamodel/ospf/OspfTopology.java 93.93% <0%> (ø) 22% <0%> (ø) ⬇️
... and 2 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants