IS-IS redistribution

[corinaminer]

• JNPR: Convert IS-IS export policy
• Apply IS-IS export policies in IBDP

[batfish-bot]

This change is 

[progwriter]

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corinaminer)

---

projects/batfish/src/main/java/org/batfish/dataplane/ibdp/VirtualRouter.java, line 1586 at r1 (raw file):

        queueDelta(queue, correctedL2Delta);
        if (upgradeL1Routes) {
          // TODO: a little cumbersome, simplify later

didn't get any less cumbersome 😞

---

projects/batfish/src/main/java/org/batfish/dataplane/ibdp/VirtualRouter.java, line 2010 at r1 (raw file):

        // Message queues
        || !_isisIncomingRoutes.values().stream().allMatch(Queue::isEmpty)
        || !_routesForIsisRedistribution.isEmpty()

needs iteration hashcode update too

[corinaminer]

Reviewable status: 5 of 8 files reviewed, all discussions resolved (waiting on @progwriter)

---

projects/batfish/src/main/java/org/batfish/dataplane/ibdp/VirtualRouter.java, line 2010 at r1 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

needs iteration hashcode update too

done

---

projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java, line 3105 at r2 (raw file):

  @Test
  public void testIsisRedistribution() throws IOException {

(same test, different file)

[progwriter]

Reviewed 3 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[codecov]

Codecov Report

Merging #5086 into master will increase coverage by 0.02%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master    #5086      +/-   ##
============================================
+ Coverage     76.78%    76.8%   +0.02%     
- Complexity    30484    30510      +26     
============================================
  Files          2434     2434              
  Lines        116987   117070      +83     
  Branches      13780    13790      +10     
============================================
+ Hits          89831    89921      +90     
+ Misses        20377    20362      -15     
- Partials       6779     6787       +8

Impacted Files	Coverage Δ	Complexity Δ
...fish/grammar/flatjuniper/ConfigurationBuilder.java	63.92% <ø> (+0.19%)	731 <0> (+2)	⬆️
...g/batfish/dataplane/ibdp/IncrementalBdpEngine.java	90.76% <100%> (ø)	84 <1> (ø)	⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	87.31% <75.47%> (-0.42%)	263 <9> (+11)
...atfish/dataplane/protocols/IsisProtocolHelper.java	79.54% <80.76%> (+0.59%)	9 <4> (+5)	⬆️
...h/representation/juniper/JuniperConfiguration.java	88.69% <92%> (+0.26%)	425 <2> (+3)	⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java	64.04% <0%> (-1.13%)	15% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java	91.25% <0%> (-0.39%)	64% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java	83.98% <0%> (-0.13%)	509% <0%> (-1%)
... and 6 more