Implement Cisco bgp neighbor local-as and add as-check to BgpSessionCheck #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
approved these changes
Oct 6, 2017
| ! | ||
| router bgp 1 | ||
| router-id 1.1.1.1 | ||
| neighbor 1.2.0.2 remote-as 2 |
There was a problem hiding this comment.
Would be nice to add a comment here explaining that the local as number is 1 because Cisco family devices default to the process id.
| @@ -376,6 +382,9 @@ private void inheritUnsetFields(BgpPeerGroup pg) { | |||
| _inboundRoute6Map = pg.getInboundRoute6Map(); | |||
| _inboundRoute6MapLine = pg.getInboundRoute6MapLine(); | |||
| } | |||
| if (_localAs == null) { | |||
| _localAs = pg.getMaximumPaths(); | |||
There was a problem hiding this comment.
this looks like a bug – copy and paste error?
| @@ -2022,7 +2022,8 @@ private AsPathAccessListLine toAsPathAccessListLine(AsPathSetElem elem) { | |||
| _w.redFlag("No remote-as set for peer: " + lpg.getName()); | |||
| continue; | |||
| } | |||
|
|
|||
| Integer pgLocalAs = lpg.getLocalAs(); | |||
| int localAs = pgLocalAs != null ? pgLocalAs : proc.getName(); | |||
There was a problem hiding this comment.
simpler: int localAs = firstNonNull(lpg.getLocalAs(), proc.getName());
There was a problem hiding this comment.
(import static com.google.common...?...MoreObjects.firstNonNull from guava)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.