Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic for identifying the subnet acl #5139

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Nov 10, 2019

and warn instead of throwing a batfishexception

…g batfishexception when unexpected things happen
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dhalperi, @progwriter, and @ratulm)


projects/batfish/src/main/java/org/batfish/representation/aws/Subnet.java, line 170 at r1 (raw file):

    } else {
      warnings.redFlag("Could not find a network ACL for subnet " + _subnetId);
    }

what's the test this change fixes?

@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8b6cacc). Click here to learn what that means.
The diff coverage is 70.58%.

@@            Coverage Diff            @@
##             master    #5139   +/-   ##
=========================================
  Coverage          ?   73.24%           
  Complexity        ?    31516           
=========================================
  Files             ?     2590           
  Lines             ?   127245           
  Branches          ?    15239           
=========================================
  Hits              ?    93196           
  Misses            ?    26742           
  Partials          ?     7307
Impacted Files Coverage Δ Complexity Δ
...in/java/org/batfish/representation/aws/Subnet.java 76.12% <68.96%> (ø) 30 <6> (?)
...ava/org/batfish/representation/aws/NetworkAcl.java 67.74% <80%> (ø) 27 <2> (?)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r2, 3 of 3 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @progwriter)

@ratulm ratulm merged commit e48cb3a into master Nov 11, 2019
@ratulm ratulm deleted the nix-batfish-exception branch November 11, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants