-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix logic for identifying the subnet acl #5139
Conversation
…g batfishexception when unexpected things happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dhalperi, @progwriter, and @ratulm)
projects/batfish/src/main/java/org/batfish/representation/aws/Subnet.java, line 170 at r1 (raw file):
} else { warnings.redFlag("Could not find a network ACL for subnet " + _subnetId); }
what's the test this change fixes?
Codecov Report
@@ Coverage Diff @@
## master #5139 +/- ##
=========================================
Coverage ? 73.24%
Complexity ? 31516
=========================================
Files ? 2590
Lines ? 127245
Branches ? 15239
=========================================
Hits ? 93196
Misses ? 26742
Partials ? 7307
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r2, 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @progwriter)
and warn instead of throwing a batfishexception