Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS layer1 (with no file written on empty layer1) #5173

Merged
merged 15 commits into from
Nov 27, 2019
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Nov 27, 2019

@progwriter - only the last commit has new changes

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #5173 into master will increase coverage by 0.02%.
The diff coverage is 92.37%.

@@             Coverage Diff              @@
##             master    #5173      +/-   ##
============================================
+ Coverage     73.33%   73.35%   +0.02%     
- Complexity    31596    31623      +27     
============================================
  Files          2590     2591       +1     
  Lines        127279   127356      +77     
  Branches      15262    15267       +5     
============================================
+ Hits          93335    93421      +86     
+ Misses        26631    26622       -9     
  Partials       7313     7313
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/batfish/representation/aws/Vpc.java 70.83% <ø> (ø) 7 <0> (ø) ⬇️
...ava/org/batfish/representation/aws/NatGateway.java 42.85% <ø> (ø) 5 <0> (ø) ⬇️
...ava/org/batfish/representation/aws/VpnGateway.java 83.6% <ø> (ø) 11 <0> (ø) ⬇️
...rg/batfish/representation/aws/InternetGateway.java 82.14% <ø> (ø) 10 <0> (ø) ⬇️
.../org/batfish/representation/aws/VpnConnection.java 70.89% <ø> (ø) 25 <0> (ø) ⬇️
...n/java/org/batfish/vendor/VendorConfiguration.java 98.13% <100%> (+0.01%) 49 <1> (+1) ⬆️
...in/java/org/batfish/representation/aws/Subnet.java 76.43% <100%> (+0.3%) 32 <2> (+2) ⬆️
...java/org/batfish/common/topology/TopologyUtil.java 92.64% <100%> (+0.14%) 141 <9> (+2) ⬆️
...in/java/org/batfish/representation/aws/Region.java 91.23% <100%> (ø) 96 <0> (ø) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 83.05% <100%> (+0.54%) 136 <4> (+5) ⬆️
... and 17 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a RN build, looks ok.

Reviewed 26 of 29 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@ratulm ratulm merged commit 464a9ff into master Nov 27, 2019
@ratulm ratulm deleted the aws-layer1-empty branch November 27, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants