Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traceroute step arp error step #5240

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Conversation

yifeiyuan
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #5240 into master will decrease coverage by <.01%.
The diff coverage is 75.86%.

@@             Coverage Diff              @@
##             master    #5240      +/-   ##
============================================
- Coverage     73.34%   73.33%   -0.01%     
  Complexity    31839    31839              
============================================
  Files          2611     2612       +1     
  Lines        128441   128470      +29     
  Branches      15429    15435       +6     
============================================
+ Hits          94199    94216      +17     
- Misses        26800    26805       +5     
- Partials       7442     7449       +7
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/batfish/datamodel/flow/Step.java 100% <ø> (ø) 3 <0> (ø) ⬇️
.../java/org/batfish/datamodel/flow/ArpErrorStep.java 75.86% <75.86%> (ø) 3 <3> (?)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 88.18% <0%> (-1.37%) 49% <0%> (-1%)
...batfish/src/main/java/org/batfish/main/Driver.java 38.25% <0%> (-0.25%) 28% <0%> (ø)

@yifeiyuan yifeiyuan merged commit 127dc4e into master Dec 13, 2019
@yifeiyuan yifeiyuan deleted the yifei-traceroute-step-arpErrorStep branch December 13, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants