Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco ASA: setup firewall sessions #5331

Merged
merged 5 commits into from
Jan 2, 2020
Merged

Cisco ASA: setup firewall sessions #5331

merged 5 commits into from
Jan 2, 2020

Conversation

sfraint
Copy link
Member

@sfraint sfraint commented Jan 1, 2020

Previously, Cisco ASA VS->VI conversion did not setup firewall sessions allowing return traffic for successful forward flows, which caused bidirectional checks to incorrectly report failures for return flows.

This PR adds sessions for ASA devices, allowing bidirectional checks to succeed (note: some more detail on ASA packet forwarding in Cisco docs).

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 1, 2020

Codecov Report

Merging #5331 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5331      +/-   ##
============================================
- Coverage     73.44%    73.4%   -0.04%     
+ Complexity    32054    32000      -54     
============================================
  Files          2624     2624              
  Lines        129258   129029     -229     
  Branches      15564    15520      -44     
============================================
- Hits          94929    94713     -216     
- Misses        26807    26810       +3     
+ Partials       7522     7506      -16
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.55% <100%> (-0.12%) 523 <0> (-1)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...ar/cumulus_frr/CumulusFrrConfigurationBuilder.java 78.71% <0%> (-3.99%) 107% <0%> (-49%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.09% <0%> (-1.82%) 49% <0%> (-2%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter and @sfraint)

a discussion (no related file):
It's simpler to test the new firewall sessions in the forward TraceAndReverseFlow directly -- we should have enough coverage for how the traceroute engine uses sessions.

Please also test the session action, etc


Copy link
Member Author

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @anothermattbrown and @progwriter)

a discussion (no related file):

Previously, anothermattbrown (Matt Brown) wrote…

It's simpler to test the new firewall sessions in the forward TraceAndReverseFlow directly -- we should have enough coverage for how the traceroute engine uses sessions.

Please also test the session action, etc

Updated to just do a simple, conversion test like we discussed


Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anothermattbrown and @progwriter)

@sfraint sfraint merged commit 6fac6bc into master Jan 2, 2020
@sfraint sfraint deleted the asa-session branch January 2, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants