Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista BGP: evpn AF allow-remote-as-out #5365

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

progwriter
Copy link
Contributor

Should always be set to true, just like for IPv4 AF

Should always be set to true, just like for IPv4 AF
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #5365 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5365      +/-   ##
============================================
- Coverage     73.31%    73.3%   -0.01%     
+ Complexity    32033    32028       -5     
============================================
  Files          2623     2623              
  Lines        129154   129154              
  Branches      15533    15533              
============================================
- Hits          94683    94671      -12     
- Misses        26954    26964      +10     
- Partials       7517     7519       +2
Impacted Files Coverage Δ Complexity Δ
...atfish/representation/cisco/AristaConversions.java 73.62% <100%> (ø) 70 <0> (ø) ⬇️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0%> (-1.37%) 50% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.93% <0%> (-0.32%) 261% <0%> (-2%)
...batfish/src/main/java/org/batfish/main/Driver.java 38.07% <0%> (-0.26%) 28% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 85.6% <0%> (-0.13%) 524% <0%> (-1%)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit aa7c237 into batfish:master Jan 7, 2020
@progwriter progwriter deleted the arista-remote-as-out branch January 7, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants