Arista BGP: flip bit to new bgp parser #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
progwriter
pushed a commit
to progwriter/batfish
that referenced
this pull request
Jan 8, 2020
While flipping the bit to new parser (batfish#5376), found test failures. Turns out VI pipeline a little incorrect so doing the fix in fixing for now.
progwriter
added a commit
that referenced
this pull request
Jan 8, 2020
While flipping the bit to new parser (#5376), found e2e default-originate test failures. Turns out VI pipeline a little incorrect so doing the fix in fixing for now.
added 5 commits
January 8, 2020 14:25
1. 'aristabgp' debug flag is now a noop 2. 'noaristabgp' debug flag now allows using the old hybrid parser
Cannot type it in an emulator. Believe to be IOS command only.
Another one of those IOS-isms.
progwriter
force-pushed
the
arista-flip-bit
branch
from
8f1007c
to
b3cb54b
Compare
dhalperi
reviewed
Jan 8, 2020
| { | ||
| "File_Name" : "configs/arista_bgp", | ||
| "Struct_Type" : "bgp peer-group", | ||
| "Ref_Name" : "UNDEFINED_PEER_GROUP", |
dhalperi
reviewed
Jan 8, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 8 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 9 of 9 files at r5, 2 of 4 files at r6, 2 of 2 files at r8.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #5376 +/- ##
=========================================
Coverage ? 73.31%
Complexity ? 32040
=========================================
Files ? 2624
Lines ? 129292
Branches ? 15559
=========================================
Hits ? 94792
Misses ? 26973
Partials ? 7527
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aristabgpdebug flag is now a noopnoaristabgpdebug flag now allows reverting to the old hybrid parser