Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: support overriding OSPF distance #5515

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Feb 4, 2020

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #5515 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5515      +/-   ##
============================================
- Coverage     73.54%   73.54%   -0.01%     
+ Complexity    32375    32373       -2     
============================================
  Files          2637     2637              
  Lines        129918   129928      +10     
  Branches      15580    15580              
============================================
+ Hits          95550    95553       +3     
- Misses        26794    26804      +10     
+ Partials       7574     7571       -3
Impacted Files Coverage Δ Complexity Δ
...n/java/org/batfish/datamodel/ospf/OspfProcess.java 90.52% <100%> (+0.2%) 51 <0> (ø) ⬇️
...batfish/representation/cisco_nxos/OspfProcess.java 94.82% <100%> (+0.28%) 31 <2> (+2) ⬆️
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 75.8% <100%> (+0.01%) 993 <1> (+1) ⬆️
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.87% <100%> (ø) 348 <3> (ø) ⬇️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0%> (-3.23%) 12% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...batfish/src/main/java/org/batfish/main/Driver.java 38.07% <0%> (-0.26%) 28% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 86.02% <0%> (-0.13%) 544% <0%> (-1%)

@dhalperi dhalperi merged commit 2b49abe into batfish:master Feb 4, 2020
@dhalperi dhalperi deleted the ospf-cost branch February 4, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants