Cisco ASA redundant interface support

[arifogel]

No description provided.

[batfish-bot]

This change is 

[progwriter]

Reviewed 15 of 15 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @arifogel)

---

projects/batfish/src/main/java/org/batfish/main/Batfish.java, line 748 at r1 (raw file):

                      .filter(Objects::nonNull)
                      .mapToDouble(Double::doubleValue)
                      .findFirst()

1. Use something more deterministic, like min()?
2. By having 0 here, you're risking division by 0 exceptions in OSPF computation. Is there a better default value? Or just leave it null?

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/Interface.java, line 1376 at r1 (raw file):

  }

  @JsonProperty(PROP_REDUNDANCY_GROUP_MEMBERS)

Why plumb this through to VI? who will use it? We do not do this for Juniper, for example.

[arifogel]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @progwriter)

---

projects/batfish/src/main/java/org/batfish/main/Batfish.java, line 748 at r1 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

1. Use something more deterministic, like min()?
2. By having 0 here, you're risking division by 0 exceptions in OSPF computation. Is there a better default value? Or just leave it null?

1. ok
2. i'm just copying logic for computeAggergatedInterfaceBandwidths above, which results in 0 if there are no live dependencies (uses sum()).

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/Interface.java, line 1376 at r1 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

Why plumb this through to VI? who will use it? We do not do this for Juniper, for example.

awesome, removed

[codecov]

Codecov Report

Merging #5542 into master will increase coverage by 0.02%.
The diff coverage is 94.66%.

@@             Coverage Diff              @@
##             master    #5542      +/-   ##
============================================
+ Coverage     73.58%    73.6%   +0.02%     
- Complexity    32448    32491      +43     
============================================
  Files          2647     2649       +2     
  Lines        130034   130192     +158     
  Branches      15543    15550       +7     
============================================
+ Hits          95680    95826     +146     
- Misses        26773    26781       +8     
- Partials       7581     7585       +4

Impacted Files	Coverage Δ	Complexity Δ
...src/main/java/org/batfish/datamodel/pojo/Link.java	80% <ø> (ø)	12 <0> (ø)	⬇️
...tfish/representation/cisco/CiscoConfiguration.java	86.22% <100%> (+0.07%)	549 <1> (+4)	⬆️
...main/java/org/batfish/datamodel/InterfaceType.java	100% <100%> (ø)	1 <0> (ø)	⬇️
...fish/representation/cisco/CiscoStructureUsage.java	100% <100%> (ø)	3 <0> (ø)	⬇️
...src/main/java/org/batfish/datamodel/Interface.java	84.93% <100%> (+0.19%)	214 <2> (+5)	⬆️
...va/org/batfish/representation/cisco/Interface.java	90.51% <100%> (+0.08%)	129 <1> (+1)	⬆️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java	67.6% <62.5%> (-0.01%)	1419 <1> (+1)
...atfish/src/main/java/org/batfish/main/Batfish.java	75.86% <97.56%> (+0.57%)	298 <13> (+15)	⬆️
...col/src/main/java/org/batfish/role/InferRoles.java	88.18% <0%> (-2.73%)	49% <0%> (-2%)
...fish/question/testfilters/TestFiltersAnswerer.java	87.68% <0%> (-2.55%)	19% <0%> (+2%)
... and 19 more

[progwriter]

Reviewed 5 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)

---

projects/batfish/src/main/java/org/batfish/main/Batfish.java, line 748 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

1. ok
2. i'm just copying logic for computeAggergatedInterfaceBandwidths above, which results in 0 if there are no live dependencies (uses sum()).

Yeah computeAggergatedInterfaceBandwidths is likely going to have this bug too, but we can fix that separately

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved

---

projects/batfish/src/main/java/org/batfish/main/Batfish.java, line 748 at r1 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

Yeah computeAggergatedInterfaceBandwidths is likely going to have this bug too, but we can fix that separately

punting for now