BDDReachabilityAnalysisFactory: fix denied out

[dhalperi]

And add comments to code, plus simplify with branch.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #5573 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5573      +/-   ##
============================================
- Coverage     73.66%   73.65%   -0.02%     
+ Complexity    32556    32547       -9     
============================================
  Files          2651     2651              
  Lines        130256   130253       -3     
  Branches      15560    15561       +1     
============================================
- Hits          95953    95934      -19     
- Misses        26719    26733      +14     
- Partials       7584     7586       +2     

Impacted Files	Coverage Δ	Complexity Δ
...ava/org/batfish/bddreachability/transition/Or.java	23.07% <0.00%> (-19.24%)	3.00% <0.00%> (-3.00%)
...org/batfish/bddreachability/transition/Branch.java	61.29% <0.00%> (-3.23%)	10.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	89.09% <0.00%> (-1.82%)	49.00% <0.00%> (-2.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	64.04% <0.00%> (-1.13%)	15.00% <0.00%> (-1.00%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java	92.72% <0.00%> (-0.39%)	68.00% <0.00%> (-1.00%)
...batfish/src/main/java/org/batfish/main/Driver.java	48.19% <0.00%> (-0.33%)	28.00% <0.00%> (ø%)
...tfish/representation/cisco/CiscoConfiguration.java	86.09% <0.00%> (-0.12%)	548.00% <0.00%> (-1.00%)

[dhalperi]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)