Juniper: add Protocol constraints for match clauses that imply them #5574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhalperi
changed the title
dhalperi
changed the title
* tcp flags: TCP * icmp types/coes: ICMP * port (src, dest, unqualified): TCP or UDP
Codecov Report
@@ Coverage Diff @@
## master #5574 +/- ##
============================================
- Coverage 73.65% 73.65% -0.01%
+ Complexity 32553 32548 -5
============================================
Files 2651 2651
Lines 130253 130268 +15
Branches 15561 15561
============================================
+ Hits 95944 95951 +7
- Misses 26725 26730 +5
- Partials 7584 7587 +3
|
yifeiyuan
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
yifeiyuan
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.