Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: allow standard community-list without standard keyword #5582

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

dhalperi
Copy link
Member

This was parsed, but crashed in extraction.

This was parsed, but crashed in extraction.
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 9ca2665 into batfish:master Feb 26, 2020
@dhalperi dhalperi deleted the arista-community-list branch February 26, 2020 23:35
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #5582 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #5582      +/-   ##
============================================
- Coverage     73.66%   73.65%   -0.01%     
+ Complexity    32562    32560       -2     
============================================
  Files          2651     2651              
  Lines        130300   130302       +2     
  Branches      15563    15564       +1     
============================================
- Hits          95984    95979       -5     
- Misses        26737    26742       +5     
- Partials       7579     7581       +2
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 67.61% <50%> (+0.01%) 1420 <0> (+1) ⬆️
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0%> (-1.37%) 50% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 86.09% <0%> (-0.12%) 548% <0%> (-1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants