Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: parse and extract interface ospf priority #5589

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

dhalperi
Copy link
Member

FWICT this has no mapping in VI right now.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #5589 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5589      +/-   ##
============================================
- Coverage     73.68%   73.68%   -0.01%     
  Complexity    32710    32710              
============================================
  Files          2661     2661              
  Lines        131006   131012       +6     
  Branches      15643    15643              
============================================
+ Hits          96535    96537       +2     
- Misses        26831    26833       +2     
- Partials       7640     7642       +2     
Impacted Files Coverage Δ Complexity Δ
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...tfish/representation/cisco_nxos/OspfInterface.java 100.00% <0.00%> (ø) 19.00% <0.00%> (+1.00%) ⬇️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 8ac2ca6 into batfish:master Feb 28, 2020
@dhalperi dhalperi deleted the ospf-priority branch February 28, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants