Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybatfish installation instruction via pypi #5610

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Mar 8, 2020

No description provided.

@ratulm ratulm requested a review from sfraint March 8, 2020 07:10
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #5610 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5610      +/-   ##
============================================
- Coverage     73.74%   73.73%   -0.02%     
+ Complexity    32835    32828       -7     
============================================
  Files          2666     2666              
  Lines        131438   131438              
  Branches      15681    15681              
============================================
- Hits          96932    96916      -16     
- Misses        26843    26856      +13     
- Partials       7663     7666       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.55% <0%> (-5.62%) 13% <0%> (-3%)
...ain/java/org/batfish/datamodel/EvpnType3Route.java 85.14% <0%> (-1%) 30% <0%> (-1%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.84% <0%> (-0.59%) 90% <0%> (-1%)
...batfish/src/main/java/org/batfish/main/Driver.java 48.19% <0%> (-0.33%) 28% <0%> (ø)
...src/main/java/org/batfish/coordinator/WorkMgr.java 69.72% <0%> (-0.27%) 282% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 86.09% <0%> (-0.12%) 548% <0%> (-1%)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sfraint)

@dhalperi dhalperi merged commit f4fe0b8 into master Mar 8, 2020
@dhalperi dhalperi deleted the ratulm-patch-1 branch March 8, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants