Added support for parsing NX-OS NetFlow stanzas #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhalperi
reviewed
Mar 23, 2020
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @agember)
projects/batfish/src/test/resources/org/batfish/grammar/cisco_nxos/testconfigs/nxos_flow, line 8 at r1 (raw file):
source Ethernet1/1
Add as interface reference?
@arifogel is it obvious the right way to do this? There's no previous keyword to look at...
Codecov Report
@@ Coverage Diff @@
## master #5646 +/- ##
============================================
- Coverage 73.78% 73.78% -0.01%
- Complexity 32899 32905 +6
============================================
Files 2667 2667
Lines 131612 131660 +48
Branches 15704 15707 +3
============================================
+ Hits 97106 97139 +33
- Misses 26840 26852 +12
- Partials 7666 7669 +3
|
dhalperi
reviewed
Mar 23, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing support for this was motivated by the inclusion of a version statement in a flow exporter stanza. Without this support, parser recovery treats the version statement as a top-level version statement (which I believe negatively impacts vendor detection). As an added benefit, there is now missing reference tracking for NetFlow-related configuration.