Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 encode workid to get work log path to prevent path traversal #5718

Merged
merged 9 commits into from
Apr 24, 2020

Conversation

arifogel
Copy link
Member

No description provided.

@arifogel arifogel requested a review from dhalperi April 23, 2020 21:03
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #5718 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #5718   +/-   ##
=========================================
  Coverage     71.37%   71.38%           
- Complexity    33639    33661   +22     
=========================================
  Files          2786     2788    +2     
  Lines        139541   139606   +65     
  Branches      16781    16792   +11     
=========================================
+ Hits          99604    99655   +51     
- Misses        32073    32077    +4     
- Partials       7864     7874   +10     
Impacted Files Coverage Δ Complexity Δ
...lient/src/main/java/org/batfish/client/Client.java 52.11% <ø> (+0.34%) 309.00 <0.00> (ø)
...ain/java/org/batfish/storage/FileBasedStorage.java 83.03% <100.00%> (+0.06%) 142.00 <5.00> (+1.00)
...ish/src/main/java/org/batfish/config/Settings.java 84.59% <100.00%> (-0.12%) 93.00 <0.00> (ø)
...a/org/batfish/datamodel/flow/MatchSessionStep.java 78.37% <0.00%> (-6.92%) 2.00% <0.00%> (ø%)
...a/org/batfish/datamodel/flow/SetupSessionStep.java 78.37% <0.00%> (-6.92%) 2.00% <0.00%> (ø%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0.00%> (-6.67%) 5.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0.00%> (-3.23%) 12.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
..._bigip_imish/F5BigipImishConfigurationBuilder.java 90.55% <0.00%> (-0.97%) 96.00% <0.00%> (+3.00%) ⬇️
... and 13 more

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 3 of 5 files at r2, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit 408d7c5 into batfish:master Apr 24, 2020
@arifogel arifogel deleted the ari-base64-work-log-path branch April 24, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants