Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven: add OWASP dependency-check to build #5738

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

dhalperi
Copy link
Member

It's really slow, so off always for now.

It's really slow, so off always for now.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #5738 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5738      +/-   ##
============================================
- Coverage     71.40%   71.40%   -0.01%     
+ Complexity    33676    33674       -2     
============================================
  Files          2788     2788              
  Lines        139584   139584              
  Branches      16790    16790              
============================================
- Hits          99668    99663       -5     
- Misses        32048    32053       +5     
  Partials       7868     7868              
Impacted Files Coverage Δ Complexity Δ
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
...batfish/src/main/java/org/batfish/main/Driver.java 48.26% <0.00%> (-0.32%) 29.00% <0.00%> (ø%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit df67fdf into batfish:master Apr 30, 2020
@dhalperi dhalperi deleted the dependency-check branch April 30, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants