FlowTracer: create a trace when policy-based routing drops a packet

[dhalperi]

No description provided.

[batfish-bot]

This change is 

[dhalperi]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anothermattbrown and @progwriter)

a discussion (no related file):
Is there an obvious best way to test this?

---

[progwriter]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anothermattbrown and @dhalperi)

a discussion (no related file):

Previously, dhalperi (Dan Halperin) wrote…

Is there an obvious best way to test this?

we only have e2e-ish tests so far 😞

You can expand If statement here for a different IP (to drop) https://github.com/batfish/batfish/blob/master/projects/allinone/src/test/java/org/batfish/question/traceroute/TraceroutePolicyBasedRoutingTest.java#L86-L93

then check for dropped trace

---

[codecov]

Codecov Report

Merging #5747 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5747      +/-   ##
============================================
- Coverage     71.43%   71.43%   -0.01%     
+ Complexity    33680    33673       -7     
============================================
  Files          2788     2788              
  Lines        139704   139705       +1     
  Branches      16794    16794              
============================================
- Hits          99800    99793       -7     
- Misses        32035    32037       +2     
- Partials       7869     7875       +6     

Impacted Files	Coverage Δ	Complexity Δ
...a/org/batfish/dataplane/traceroute/FlowTracer.java	91.63% <100.00%> (+0.40%)	87.00 <0.00> (ø)
...c/main/java/org/batfish/dataplane/rib/RibTree.java	89.58% <0.00%> (-4.17%)	27.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java	87.09% <0.00%> (-3.23%)	12.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java	65.78% <0.00%> (-2.64%)	15.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	89.54% <0.00%> (-1.37%)	50.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	88.04% <0.00%> (-0.32%)	262.00% <0.00%> (-2.00%)

[anothermattbrown]

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved