Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: support ACL references in snmp-server group v3 #5810

Merged
merged 1 commit into from May 13, 2020

Conversation

dhalperi
Copy link
Member

Fix #5793

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @arifogel and @progwriter)


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/Cisco_snmp.g4, line 108 at r1 (raw file):

:
  V3
  level = (AUTH | NOAUTH | PRIV)

FYI order did matter for these options in csr1000v.


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoLexer.g4, line 5169 at r1 (raw file):

   'group'
   {
     if (lastTokenType() == SNMP_SERVER) {

trying to move towards better grammar without too much work

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #5810 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5810      +/-   ##
============================================
+ Coverage     71.60%   71.91%   +0.31%     
- Complexity    33828    33843      +15     
============================================
  Files          2787     2789       +2     
  Lines        139909   139487     -422     
  Branches      16830    16770      -60     
============================================
+ Hits         100180   100317     +137     
+ Misses        31839    31284     -555     
+ Partials       7890     7886       -4     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.74% <ø> (-0.14%) 490.00 <0.00> (-1.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.16% <100.00%> (+0.05%) 1186.00 <3.00> (+3.00)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...atfish/bddreachability/SessionInstrumentation.java 87.34% <0.00%> (-4.21%) 27.00% <0.00%> (-6.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/common/BatfishLogger.java 79.33% <0.00%> (-0.67%) 37.00% <0.00%> (-1.00%)
.../main/java/org/batfish/client/config/Settings.java 80.74% <0.00%> (-0.15%) 26.00% <0.00%> (ø%)
...ient/src/main/java/org/batfish/client/Command.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...col/src/main/java/org/batfish/common/BfConsts.java 83.33% <0.00%> (ø) 1.00% <0.00%> (ø%)
... and 14 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit 19cad80 into batfish:master May 13, 2020
@dhalperi dhalperi deleted the ios-snmp branch May 13, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco Standard ACL being flagged as Unused Structure in SNMPv3 Group
3 participants