Cisco IOS line parsing improvements #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix batfish#5831 - warn instead of crash for unsupported line ranges, i.e. where last number of range end is smaller than last number of range start - parse and ignore some other constructs
|
This change is |
dhalperi
reviewed
May 28, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ratulm)
Codecov Report
@@ Coverage Diff @@
## master #5833 +/- ##
============================================
- Coverage 71.90% 71.90% -0.01%
+ Complexity 33867 33865 -2
============================================
Files 2791 2791
Lines 139522 139527 +5
Branches 16752 16752
============================================
Hits 100328 100328
- Misses 31313 31317 +4
- Partials 7881 7882 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
number of range end is smaller than last number of range start