Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: fix a crash in malformed isakmp profiles #5851

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Jun 2, 2020

Fix #5849

@dhalperi dhalperi requested a review from progwriter June 2, 2020 17:59
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #5851 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5851      +/-   ##
============================================
- Coverage     71.99%   71.99%   -0.01%     
+ Complexity    33878    33869       -9     
============================================
  Files          2793     2793              
  Lines        139556   139561       +5     
  Branches      16769    16769              
============================================
- Hits         100479   100472       -7     
- Misses        31209    31218       +9     
- Partials       7868     7871       +3     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/batfish/datamodel/IkePhase1Policy.java 95.00% <100.00%> (+0.26%) 11.00 <1.00> (ø)
...batfish/representation/cisco/CiscoConversions.java 88.12% <100.00%> (+0.38%) 175.00 <0.00> (+2.00)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0.00%> (-6.67%) 5.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0.00%> (-3.23%) 11.00% <0.00%> (-2.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 62.92% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 92.72% <0.00%> (-0.39%) 68.00% <0.00%> (-1.00%)
... and 4 more

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 6747461 into batfish:master Jun 2, 2020
@dhalperi dhalperi deleted the gh-5849 branch June 2, 2020 20:47
arifogel pushed a commit to arifogel/batfish that referenced this pull request Jun 3, 2020
kylehoferamzn pushed a commit to kylehoferamzn/batfish that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IKE Policy and CryptoMap Config Parsing Issue
3 participants