ClusterId Support to FRR #5856
ClusterId Support to FRR #5856
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @kylehoferamzn)
a discussion (no related file):
Can you please split this into two PRs? Don't want to mix vendor-specific changes w/ VI question changes. thanks.
Done. Other PR: #5857 |
There was a problem hiding this comment.
Reviewed 7 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kylehoferamzn)
projects/batfish/src/test/java/org/batfish/representation/cumulus/CumulusConversionsTest.java, line 1232 at r3 (raw file):
} public void testInferClusterId_eBGP() {
missing test annotation here
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5.
Reviewable status:
Adds clusterID parsing and functionality to FRR models, also adds Cluster List and Originator Id to BGP RIB output questions.