Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: support service-object ip #5887

Merged
merged 3 commits into from Jun 10, 2020
Merged

Conversation

dhalperi
Copy link
Member

Fix #5875.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #5887 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5887      +/-   ##
============================================
- Coverage     72.03%   72.03%   -0.01%     
+ Complexity    34019    34018       -1     
============================================
  Files          2805     2805              
  Lines        139888   139890       +2     
  Branches      16802    16803       +1     
============================================
+ Hits         100771   100772       +1     
- Misses        31229    31233       +4     
+ Partials       7888     7885       -3     
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/representation/cisco/ServiceObject.java 82.14% <ø> (ø) 9.00 <0.00> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.36% <100.00%> (+0.06%) 1195.00 <2.00> (+3.00)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0.00%> (-6.67%) 5.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit e82abcf into batfish:master Jun 10, 2020
@dhalperi dhalperi deleted the asa-service-group branch June 10, 2020 23:35
kylehoferamzn pushed a commit to kylehoferamzn/batfish that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco ASA Object Parsing Issues
3 participants