New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASA: support service-object ip #5887
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5887 +/- ##
============================================
- Coverage 72.03% 72.03% -0.01%
+ Complexity 34019 34018 -1
============================================
Files 2805 2805
Lines 139888 139890 +2
Branches 16802 16803 +1
============================================
+ Hits 100771 100772 +1
- Misses 31229 31233 +4
+ Partials 7888 7885 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Fix #5875.