Juniper: add support for more characters in GroupWildcard #5956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juniper example:
interfaces {
"<ge-1/2/[5-8]>" {
description "These interfaces reserved for Customer ABC";
}
}
Siva example on Batfish SLack: dd.d[dd]d.*.*/d[dd] where d is a digit
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #5956 +/- ##
============================================
- Coverage 72.16% 72.15% -0.01%
+ Complexity 34254 34247 -7
============================================
Files 2810 2810
Lines 140665 140668 +3
Branches 16909 16909
============================================
- Hits 101514 101505 -9
- Misses 31245 31253 +8
- Partials 7906 7910 +4
|
progwriter
reviewed
Jul 2, 2020
There was a problem hiding this comment.
surprised diff coverage is 0, but
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
kylehoferamzn
pushed a commit
to kylehoferamzn/batfish
that referenced
this pull request
Jul 21, 2020
Juniper example:
interfaces {
"<ge-1/2/[5-8]>" {
description "These interfaces reserved for Customer ABC";
}
}
Siva example on Batfish Slack: dd.d[dd]d.*.*/d[dd] where d is a digit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Juniper example:
interfaces {
"<ge-1/2/[5-8]>" {
description "These interfaces reserved for Customer ABC";
}
}
Siva example on Batfish SLack: dd.d[dd]d../d[dd] where d is a digit