Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR: parse and warn on ACL udf statements #6006

Merged
merged 1 commit into from Jul 17, 2020

Conversation

dhalperi
Copy link
Member

Fix #6004 - UDFs are not supported but they are warned on. cc: @SivaKesava1

Fix batfish#6004 - UDFs are not supported but they are warned on.
@dhalperi dhalperi requested a review from progwriter July 17, 2020 23:15
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #6006 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6006      +/-   ##
============================================
+ Coverage     72.21%   72.22%   +0.01%     
- Complexity    34321    34325       +4     
============================================
  Files          2810     2810              
  Lines        140882   140882              
  Branches      16928    16928              
============================================
+ Hits         101736   101755      +19     
+ Misses        31244    31165      -79     
- Partials       7902     7962      +60     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 62.92% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.04% <0.00%> (-0.32%) 262.00% <0.00%> (-2.00%)
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 19.08% <0.00%> (+0.45%) 320.00% <0.00%> (+7.00%)
...org/batfish/representation/cisco_xr/Interface.java 52.17% <0.00%> (+2.17%) 63.00% <0.00%> (+2.00%)
...co_xr/UnimplementedAccessListServiceSpecifier.java 50.00% <0.00%> (+50.00%) 1.00% <0.00%> (+1.00%)

@dhalperi dhalperi merged commit 5ff51e0 into batfish:master Jul 17, 2020
@dhalperi dhalperi deleted the xr-acl-udf branch July 17, 2020 23:27
kylehoferamzn pushed a commit to kylehoferamzn/batfish that referenced this pull request Jul 21, 2020
Fix batfish#6004 - UDFs are not supported but they are warned on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different ACLs are recognized as a single ACL in Cisco
3 participants