XR: parse and warn on as-path-set passes-through #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get this implemented correctly, we need to do a similar overhaul to AS matching as we did to Community matching. But this prevents a conversion error.
|
This change is |
progwriter
reviewed
Jul 18, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
dhalperi
commented
Jul 18, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## master #6008 +/- ##
============================================
- Coverage 72.23% 72.22% -0.01%
+ Complexity 34329 34324 -5
============================================
Files 2810 2810
Lines 140882 140887 +5
Branches 16928 16928
============================================
- Hits 101761 101759 -2
- Misses 31159 31164 +5
- Partials 7962 7964 +2
|
progwriter
reviewed
Jul 18, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
kylehoferamzn
pushed a commit
to kylehoferamzn/batfish
that referenced
this pull request
Jul 21, 2020
To get this implemented correctly, we need to do a similar overhaul to AS matching as we did to Community matching. But this prevents a conversion error. Fix batfish#6005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get this implemented correctly, we need to do a similar overhaul to
AS matching as we did to Community matching. But this prevents a conversion error.
Fix #6005.