Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IOS_XR interface names #6016

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Update IOS_XR interface names #6016

merged 6 commits into from
Jul 20, 2020

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Jul 20, 2020

Fixes #5998 and meant to replace#6002

Per @dhalperi suggestion, this PR updates the interface name mapping for IOS_XR to align with with the list below.
One thing that is not clear to me is : Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?

Reference list, from a IOS_XR 6.6.3

  BVI              Bridge-Group Virtual Interface
  Bundle-Ether     Aggregated Ethernet interface(s) | short name is BE
  Bundle-POS       Aggregated POS interface(s) | short name is BP
  FastEthernet     FastEthernet/IEEE 802.3 interface(s) | short name is Fa
  FiftyGigE        FiftyGigabitEthernet/IEEE 802.3 interface(s) | short name is Fi
  FortyGigE        FortyGigabitEthernet/IEEE 802.3 interface(s) | short name is Fo
  FourHundredGigE  FourHundredGigabitEthernet/IEEE 802.3 interface(s) | short name is F
  GCC0             OTN GCC0 interface(s) | short name is G0
  GCC1             OTN GCC1 interface(s) | short name is G1
  GigabitEthernet  GigabitEthernet/IEEE 802.3 interface(s) | short name is Gi
  HundredGigE      HundredGigabitEthernet/IEEE 802.3 interface(s) | short name is Hu
  Loopback         Loopback interface(s) | short name is Lo
  MgmtEth          Ethernet/IEEE 802.3 interface(s) | short name is Mg
  Multilink        Multilink network interface(s) | short name is Ml
  Null             Null interface | short name is Nu
  POS              Packet over SONET/SDH network interface(s) | short name is POS
  PW-Ether         PWHE Ethernet Interface | short name is PE
  PW-IW            PWHE VC11 IP Interworking Interface | short name is PI
  SRP              SRP interface(s) | short name is SRP
  Serial           Serial network interface(s) | short name is Se
  TenGigE          TenGigabitEthernet/IEEE 802.3 interface(s) | short name is Te
  TwentyFiveGigE   TwentyFiveGigabitEthernet/IEEE 802.3 interface(s) | short name is TF
  TwoHundredGigE   TwoHundredGigabitEthernet/IEEE 802.3 interface(s) | short name is TH
  preconfigure     Specify a preconfig
  tunnel-ip        GRE/IPinIP Tunnel Interface(s)
  tunnel-ipsec     IPSec Tunnel interface(s) | short name is tsec
  tunnel-mte       MPLS Traffic Engineering P2MP Tunnel interface(s) | short name is tm
  tunnel-te        MPLS Traffic Engineering Tunnel interface(s) | short name is tt
  tunnel-tp        MPLS Transport Protocol Tunnel interface | short name is tp  BVI              Bridge-Group Virtual Interface

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dgarros)

a discussion (no related file):

Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?

Yes - so we get case normalization. I think there are still many missing, like gcc0 and bundle-pos


Copy link
Contributor Author

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)

a discussion (no related file):

Previously, dhalperi (Dan Halperin) wrote…

Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?

Yes - so we get case normalization. I think there are still many missing, like gcc0 and bundle-pos

I will work on that now, I was focusing on getting the tests to pass first.


Copy link
Contributor Author

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 10 files reviewed, 1 unresolved discussion (waiting on @dhalperi)

a discussion (no related file):

Previously, dgarros (Damien Garros) wrote…

I will work on that now, I was focusing on getting the tests to pass first.

@dhalperi should be good to review, I think we have all interfaces now.


Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco NCS - Generated Interface name is not valid
3 participants