-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IOS_XR interface names #6016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dgarros)
a discussion (no related file):
Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?
Yes - so we get case normalization. I think there are still many missing, like gcc0 and bundle-pos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)
a discussion (no related file):
Previously, dhalperi (Dan Halperin) wrote…
Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?Yes - so we get case normalization. I think there are still many missing, like gcc0 and bundle-pos
I will work on that now, I was focusing on getting the tests to pass first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 10 files reviewed, 1 unresolved discussion (waiting on @dhalperi)
a discussion (no related file):
Previously, dgarros (Damien Garros) wrote…
I will work on that now, I was focusing on getting the tests to pass first.
@dhalperi should be good to review, I think we have all interfaces now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 2 of 2 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #5998 and meant to replace#6002
Per @dhalperi suggestion, this PR updates the interface name mapping for IOS_XR to align with with the list below.
One thing that is not clear to me is : Do we need to have everything in this list, even if it's not doing any translation.
For example, is this line still required : .put("Bundle-Ether", "Bundle-Ether") ?
Reference list, from a IOS_XR 6.6.3