Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR: basic support for bundle interfaces #6019

Merged
merged 1 commit into from Jul 21, 2020

Conversation

dhalperi
Copy link
Member

Fix #6018

@dhalperi dhalperi requested a review from progwriter July 21, 2020 19:06
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #6019 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6019   +/-   ##
=========================================
  Coverage     72.24%   72.25%           
+ Complexity    34352    34351    -1     
=========================================
  Files          2810     2810           
  Lines        140938   140939    +1     
  Branches      16935    16936    +1     
=========================================
+ Hits         101827   101837   +10     
+ Misses        31161    31151   -10     
- Partials       7950     7951    +1     
Impacted Files Coverage Δ Complexity Δ
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 19.36% <100.00%> (+0.16%) 326.00 <2.00> (+4.00)
.../representation/cisco_xr/CiscoXrConfiguration.java 51.00% <100.00%> (+0.25%) 110.00 <16.00> (+2.00)
...org/batfish/representation/cisco_xr/Interface.java 53.26% <100.00%> (+1.08%) 64.00 <2.00> (+1.00)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0.00%> (-6.67%) 5.00% <0.00%> (-1.00%)
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) 7.00% <0.00%> (-2.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0.00%> (-3.23%) 11.00% <0.00%> (-2.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 62.92% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit cd21308 into batfish:master Jul 21, 2020
@dhalperi dhalperi deleted the xr-bundle-id branch July 21, 2020 19:26
@dgarros
Copy link
Contributor

dgarros commented Jul 21, 2020

Thank you for this super quick fix, I'll test it in the next build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco IOS XR - Bundle interface / Bundle member not recognized properly
4 participants