Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: track ACLs used in crypto map matching address #6043

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

dhalperi
Copy link
Member

Fix #6042.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm and @sfraint)

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm and @sfraint)

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #6043 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6043   +/-   ##
=========================================
  Coverage     72.31%   72.32%           
+ Complexity    34417    34415    -2     
=========================================
  Files          2815     2815           
  Lines        141327   141333    +6     
  Branches      16981    16981           
=========================================
+ Hits         102207   102213    +6     
+ Misses        31100    31099    -1     
- Partials       8020     8021    +1     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 86.08% <ø> (ø) 495.00 <0.00> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.39% <100.00%> (+0.03%) 1196.00 <1.00> (+1.00)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 62.92% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
...g/batfish/datamodel/flow/IncomingSessionScope.java 100.00% <0.00%> (+15.38%) 8.00% <0.00%> (+1.00%)

@dhalperi dhalperi merged commit 1394ecd into batfish:master Jul 31, 2020
@dhalperi dhalperi deleted the gh-6042 branch July 31, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bfq.unusedStructures() return false positive on Cisco ASA ACL
3 participants