Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: redo logging entirely #6090

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Conversation

dhalperi
Copy link
Member

Delete grammar, add a show all test, redo grammar.

@batfish-bot
Copy link

This change is Reviewable

Delete grammar, add a show all test, redo grammar
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #6090 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6090      +/-   ##
============================================
+ Coverage     72.62%   72.68%   +0.05%     
- Complexity    34643    34647       +4     
============================================
  Files          2814     2815       +1     
  Lines        141508   141416      -92     
  Branches      16988    16968      -20     
============================================
+ Hits         102772   102790      +18     
+ Misses        30571    30455     -116     
- Partials       8165     8171       +6     
Impacted Files Coverage Δ Complexity Δ
...sh/grammar/arista/AristaControlPlaneExtractor.java 32.94% <100.00%> (+1.15%) 576.00 <4.00> (+7.00)
...ish/representation/arista/AristaConfiguration.java 53.53% <100.00%> (+0.32%) 156.00 <1.00> (+1.00)
...sh/representation/arista/AristaStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...org/batfish/representation/arista/LoggingHost.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...in/java/org/batfish/representation/arista/Vrf.java 45.94% <100.00%> (+8.44%) 10.00 <3.00> (+3.00)
...rg/batfish/identifiers/StorageBasedIdResolver.java 88.88% <0.00%> (-4.45%) 27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 62.92% <0.00%> (-1.13%) 15.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
... and 7 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 4a269f0 into batfish:master Aug 14, 2020
@dhalperi dhalperi deleted the arista-logging branch August 14, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants