Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiscoGenericParser: normalize to Port-channel #6104

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

dhalperi
Copy link
Member

IOS and IOS-XE, at least recent releases, normalize this way.

Arista is Port-Channel, but has been factored out.
NX-OS is port-channel.

Since we've moved those out, we can do this change.

Fixes a user complaint from Marek Zbroch of NTC on Slack.

IOS and IOS-XE, at least recent releases, normalize this way.

Arista is Port-Channel, but has been factored out.
NX-OS is port-channel.

Since we've moved those out, we can do this change.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #6104 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6104      +/-   ##
============================================
- Coverage     72.72%   72.71%   -0.01%     
+ Complexity    34650    34642       -8     
============================================
  Files          2815     2815              
  Lines        141272   141271       -1     
  Branches      16964    16964              
============================================
- Hits         102737   102724      -13     
- Misses        30374    30379       +5     
- Partials       8161     8168       +7     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/batfish/datamodel/Interface.java 83.71% <100.00%> (ø) 221.00 <0.00> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.21% <100.00%> (+0.01%) 1189.00 <0.00> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 85.94% <100.00%> (ø) 493.00 <0.00> (ø)
...va/org/batfish/representation/cisco/Interface.java 88.62% <100.00%> (ø) 115.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
... and 1 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 53a5f28 into batfish:master Aug 18, 2020
@dhalperi dhalperi deleted the port-channel branch August 18, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants