VirtualRouter: uniquify export BGP Routes #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process of exporting a BGP route changes the properties, so routes that are distinct going in may be identical coming out. Before queueing the routes for import on the neighbor, uniquify them. On some large networks, this results in up to 100x fewer queued routes.
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #6123 +/- ##
============================================
- Coverage 72.71% 72.71% -0.01%
+ Complexity 34656 34654 -2
============================================
Files 2815 2815
Lines 141351 141392 +41
Branches 16971 16975 +4
============================================
+ Hits 102788 102815 +27
- Misses 30407 30413 +6
- Partials 8156 8164 +8
|
progwriter
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of exporting a BGP route changes the properties, so routes
that are distinct going in may be identical coming out. Before queueing
the routes for import on the neighbor, uniquify them.
On some large networks, this results in up to 100x fewer queued routes.