Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: route-map set distance #6126

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

dhalperi
Copy link
Member

  1. start leaving a path to convert route-map to Arista format
  2. implement route-map set distance

Rename rule more modern, remove one layer of grammar prediction
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #6126 into master will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master    #6126      +/-   ##
============================================
- Coverage     72.72%   72.71%   -0.01%     
+ Complexity    34665    34663       -2     
============================================
  Files          2815     2816       +1     
  Lines        141408   141418      +10     
  Branches      16977    16977              
============================================
- Hits         102833   102832       -1     
- Misses        30414    30422       +8     
- Partials       8161     8164       +3     
Impacted Files Coverage Δ Complexity Δ
...representation/arista/RouteMapSetDistanceLine.java 83.33% <83.33%> (ø) 2.00 <2.00> (?)
...sh/grammar/arista/AristaControlPlaneExtractor.java 33.38% <100.00%> (+0.05%) 586.00 <1.00> (+1.00)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.29% <0.00%> (-0.40%) 257.00% <0.00%> (ø%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 92.72% <0.00%> (-0.39%) 68.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...tfish/representation/cisco/CiscoConfiguration.java 85.81% <0.00%> (-0.14%) 492.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 77.41% <0.00%> (-0.14%) 284.00% <0.00%> (-1.00%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 74cdd54 into batfish:master Aug 24, 2020
@dhalperi dhalperi deleted the arista-if-speed branch August 24, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants