Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN: add security rule trace elements that link to the vendor structure #6141

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

dhalperi
Copy link
Member

No description provided.

@dhalperi dhalperi requested a review from sfraint August 26, 2020 21:37
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @sfraint)

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #6141 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6141   +/-   ##
=========================================
  Coverage     72.74%   72.74%           
  Complexity    34681    34681           
=========================================
  Files          2816     2816           
  Lines        141554   141561    +7     
  Branches      16985    16985           
=========================================
+ Hits         102968   102975    +7     
  Misses        30422    30422           
  Partials       8164     8164           
Impacted Files Coverage Δ Complexity Δ
...epresentation/palo_alto/PaloAltoConfiguration.java 87.05% <100.00%> (+0.02%) 326.00 <1.00> (+1.00)
...tation/palo_alto/PaloAltoTraceElementCreators.java 100.00% <100.00%> (ø) 10.00 <1.00> (ø)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 90.32% <0.00%> (+3.22%) 13.00% <0.00%> (+1.00%)

@dhalperi dhalperi merged commit 3d84d6c into batfish:master Aug 26, 2020
@dhalperi dhalperi deleted the pan-trace branch August 26, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants