Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteIsClassful: adjust for #6066 #6192

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

dhalperi
Copy link
Member

Apparently Cisco IOS will redistribute short prefixes, too.

Fix #6066

Apparently Cisco IOS will redistribute short prefixes, too.

Fix batfish#6066
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #6192 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6192      +/-   ##
============================================
- Coverage     72.90%   72.89%   -0.02%     
+ Complexity    34870    34863       -7     
============================================
  Files          2826     2826              
  Lines        142135   142135              
  Branches      17067    17067              
============================================
- Hits         103629   103608      -21     
- Misses        30309    30327      +18     
- Partials       8197     8200       +3     
Impacted Files Coverage Δ Complexity Δ
...datamodel/routing_policy/expr/RouteIsClassful.java 88.88% <100.00%> (ø) 6.00 <0.00> (ø)
...rg/batfish/identifiers/StorageBasedIdResolver.java 88.88% <0.00%> (-4.45%) 27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 80.64% <0.00%> (-3.23%) 13.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.36% <0.00%> (-0.65%) 259.00% <0.00%> (ø%)
...batfish/src/main/java/org/batfish/main/Driver.java 51.06% <0.00%> (-0.43%) 21.00% <0.00%> (ø%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 77.45% <0.00%> (-0.27%) 284.00% <0.00%> (ø%)
... and 3 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit e648ea4 into batfish:master Sep 14, 2020
@dhalperi dhalperi deleted the fix-6066 branch September 14, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco IOS will redistribute (without subnets keyword) shorter prefixes than their class
3 participants