Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN: add application trace details for security rules #6213

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

sfraint
Copy link
Member

@sfraint sfraint commented Sep 16, 2020

Add top-level application tracing for Palo Alto security rules.
There is no recursive tracing for applications yet (similar to addresses and services).


For example, traces for rules matching an application might look something like this:

If the rule specifies an application group and a descendant of that group is matched:

Matched security rule RULE2
   Matched source address
      Matched address object addr2
   Matched destination address
      Matched address-group addr_group1
   Matched service application-default
      Matched application-group app_group1

or if the rule specifies an application directly, which is matched:

Matched security rule RULE2
   Matched source address
      Matched address object addr2
   Matched destination address
      Matched address-group addr_group1
   Matched service application-default
      Matched built-in application bgp

Because of how applications are matched (based on service values), they show up under the Matched service application-default trace details.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #6213 into master will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #6213      +/-   ##
============================================
- Coverage     72.93%   72.91%   -0.03%     
+ Complexity    34924    34917       -7     
============================================
  Files          2826     2826              
  Lines        142237   142258      +21     
  Branches      17081    17079       -2     
============================================
- Hits         103745   103728      -17     
- Misses        30287    30314      +27     
- Partials       8205     8216      +11     
Impacted Files Coverage Δ Complexity Δ
...tation/palo_alto/PaloAltoTraceElementCreators.java 89.83% <57.14%> (-10.17%) 24.00 <3.00> (+3.00) ⬇️
...epresentation/palo_alto/PaloAltoConfiguration.java 87.75% <87.87%> (+0.14%) 350.00 <9.00> (+3.00)
...ish/representation/palo_alto/ApplicationGroup.java 90.90% <100.00%> (ø) 8.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 55.55% <0.00%> (-4.94%) 14.00% <0.00%> (-2.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 88.88% <0.00%> (-4.45%) 27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 60.37% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
... and 6 more

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit e9fd145 into master Sep 16, 2020
@dhalperi dhalperi deleted the pan-app-trace branch September 16, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants