Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: extract SNMP community information #6219

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #6219 into master will decrease coverage by 0.01%.
The diff coverage is 96.42%.

@@             Coverage Diff              @@
##             master    #6219      +/-   ##
============================================
- Coverage     72.94%   72.93%   -0.02%     
- Complexity    34931    34935       +4     
============================================
  Files          2826     2827       +1     
  Lines        142258   142283      +25     
  Branches      17079    17080       +1     
============================================
+ Hits         103766   103770       +4     
- Misses        30287    30301      +14     
- Partials       8205     8212       +7     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco_nxos/SnmpCommunity.java 92.30% <92.30%> (ø) 7.00 <7.00> (?)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 76.12% <100.00%> (+0.06%) 1024.00 <4.00> (+4.00)
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.84% <100.00%> (+0.01%) 351.00 <1.00> (+1.00)
.../org/batfish/minesweeper/bdd/TransferBDDState.java 87.50% <0.00%> (-12.50%) 3.00% <0.00%> (ø%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 88.88% <0.00%> (-4.45%) 27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.36% <0.00%> (-0.91%) 259.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 77.45% <0.00%> (-0.41%) 283.00% <0.00%> (-2.00%)
... and 5 more

@dhalperi dhalperi merged commit 1963f71 into batfish:master Sep 18, 2020
@dhalperi dhalperi deleted the nxos-snmp-community branch September 18, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants