Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: populate SNMP client IPs #6227

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #6227 into master will increase coverage by 0.00%.
The diff coverage is 82.92%.

@@            Coverage Diff            @@
##             master    #6227   +/-   ##
=========================================
  Coverage     72.94%   72.94%           
- Complexity    34953    34956    +3     
=========================================
  Files          2827     2827           
  Lines        142350   142382   +32     
  Branches      17094    17100    +6     
=========================================
+ Hits         103838   103864   +26     
+ Misses        30297    30296    -1     
- Partials       8215     8222    +7     
Impacted Files Coverage Δ Complexity Δ
...sh/grammar/arista/AristaControlPlaneExtractor.java 33.85% <ø> (+0.13%) 597.00 <0.00> (+4.00)
.../representation/arista/ExtendedAccessListLine.java 77.41% <0.00%> (ø) 7.00 <0.00> (ø)
.../representation/arista/StandardAccessListLine.java 65.21% <ø> (+8.69%) 4.00 <0.00> (+2.00)
...epresentation/arista/WildcardAddressSpecifier.java 33.33% <25.00%> (ø) 2.00 <1.00> (ø)
...ish/representation/arista/AristaConfiguration.java 54.47% <91.66%> (+0.77%) 163.00 <7.00> (+6.00)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 80.64% <0.00%> (-3.23%) 13.00% <0.00%> (-1.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
... and 5 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)

@dhalperi dhalperi merged commit da4faf0 into batfish:master Sep 22, 2020
@dhalperi dhalperi deleted the arista-snmp-clients branch September 22, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants