Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: route-map match as-number #6231

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Conversation

dhalperi
Copy link
Member

https://www.cisco.com/c/m/en_us/techdoc/dc/reference/cli/nxos/commands/bgp/match-as-number.html

This is used

to provide a list of AS numbers or an AS-path access list using a regular
expression. BGP uses this match criteria to determine which BGP peers to
create a BGP session with.

https://www.cisco.com/c/m/en_us/techdoc/dc/reference/cli/nxos/commands/bgp/match-as-number.html

This is used

>  to provide a list of AS numbers or an AS-path access list using a regular
>  expression. BGP uses this match criteria to determine which BGP peers to
>  create a BGP session with.
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #6231 into master will decrease coverage by 0.02%.
The diff coverage is 73.91%.

@@             Coverage Diff              @@
##             master    #6231      +/-   ##
============================================
- Coverage     72.96%   72.93%   -0.03%     
+ Complexity    34967    34963       -4     
============================================
  Files          2827     2828       +1     
  Lines        142382   142387       +5     
  Branches      17100    17100              
============================================
- Hits         103885   103854      -31     
- Misses        30284    30305      +21     
- Partials       8213     8228      +15     
Impacted Files Coverage Δ Complexity Δ
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.30% <50.00%> (-0.05%) 358.00 <0.00> (ø)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 76.11% <58.33%> (-0.06%) 1027.00 <2.00> (+2.00) ⬇️
...src/main/java/org/batfish/datamodel/LongSpace.java 88.23% <100.00%> (+0.35%) 15.00 <1.00> (+1.00)
...tfish/representation/cisco_nxos/RouteMapEntry.java 100.00% <100.00%> (ø) 52.00 <2.00> (+2.00)
...presentation/cisco_nxos/RouteMapMatchAsNumber.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...rg/batfish/identifiers/StorageBasedIdResolver.java 88.88% <0.00%> (-4.45%) 27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 84.78% <0.00%> (-4.35%) 16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0.00%> (-4.17%) 27.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 80.64% <0.00%> (-3.23%) 13.00% <0.00%> (-1.00%)
.../org/batfish/representation/aws/SecurityGroup.java 52.30% <0.00%> (-2.49%) 18.00% <0.00%> (+3.00%) ⬇️
... and 14 more

@dhalperi dhalperi merged commit 6f53084 into batfish:master Sep 23, 2020
@dhalperi dhalperi deleted the nxos-rmm-as-number branch September 23, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants