Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: extract route-map match as-number for dynamic bgp peers #6232

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #6232 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #6232      +/-   ##
============================================
+ Coverage     72.94%   72.95%   +0.01%     
- Complexity    34966    34981      +15     
============================================
  Files          2828     2828              
  Lines        142387   142404      +17     
  Branches      17100    17105       +5     
============================================
+ Hits         103858   103896      +38     
+ Misses        30301    30283      -18     
+ Partials       8228     8225       -3     
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/representation/cisco_nxos/RouteMap.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...batfish/representation/cisco_nxos/Conversions.java 77.77% <63.63%> (+3.76%) 71.00 <3.00> (+11.00)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 76.40% <100.00%> (+0.28%) 1030.00 <0.00> (+3.00)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...batfish/src/main/java/org/batfish/main/Driver.java 51.06% <0.00%> (-0.43%) 21.00% <0.00%> (ø%)
...tfish/representation/cisco/CiscoConfiguration.java 85.91% <0.00%> (-0.14%) 492.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.62% <0.00%> (+0.25%) 259.00% <0.00%> (ø%)
...representation/cisco_nxos/BgpVrfConfiguration.java 54.68% <0.00%> (+1.56%) 22.00% <0.00%> (+1.00%)
... and 1 more

@dhalperi dhalperi merged commit 6fbbe2f into batfish:master Sep 23, 2020
@dhalperi dhalperi deleted the nxos-rmm-as-number branch September 23, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants