Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the referenced structures part of batfish/batfish#6249 #6261

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Oct 1, 2020

It's expensive in rare cases, and also significantly more expensive to turn into
IntegerSpace dynamically (deep in a nested map).

It's expensive in rare cases, and also significantly more expensive to turn into
IntegerSpace dynamically (deep in a nested map).
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #6261 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6261      +/-   ##
============================================
- Coverage     72.89%   72.89%   -0.01%     
+ Complexity    35003    35000       -3     
============================================
  Files          2832     2832              
  Lines        142263   142258       -5     
  Branches      17085    17082       -3     
============================================
- Hits         103705   103701       -4     
- Misses        30324    30328       +4     
+ Partials       8234     8229       -5     
Impacted Files Coverage Δ Complexity Δ
...rencedstructures/ReferencedStructuresAnswerer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...del/answers/ConvertConfigurationAnswerElement.java 95.34% <100.00%> (ø) 21.00 <1.00> (ø)
...n/java/org/batfish/vendor/VendorConfiguration.java 97.24% <100.00%> (ø) 50.00 <2.00> (-1.00)
...sh/question/UndefinedReferencesQuestionPlugin.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.69% <0.00%> (-0.32%) 245.00% <0.00%> (-1.00%)
...tfish/representation/cisco/CiscoConfiguration.java 85.91% <0.00%> (-0.14%) 492.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 82.11% <0.00%> (+0.41%) 131.00% <0.00%> (-1.00%) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 60.49% <0.00%> (+1.23%) 16.00% <0.00%> (+1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 61.63% <0.00%> (+1.25%) 44.00% <0.00%> (+1.00%)

@dhalperi dhalperi merged commit 6cea459 into batfish:master Oct 1, 2020
@dhalperi dhalperi deleted the ref-rollback branch October 1, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants