Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing for EIGRP distribute list out #6269

Merged
merged 1 commit into from
Oct 1, 2020
Merged

parsing for EIGRP distribute list out #6269

merged 1 commit into from
Oct 1, 2020

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Oct 1, 2020

Partially fixes #6237 by adding parsing for distribute-list in

(Prefix lists are not supported yet)

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #6269 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6269      +/-   ##
============================================
- Coverage     72.91%   72.89%   -0.02%     
+ Complexity    35011    35001      -10     
============================================
  Files          2832     2832              
  Lines        142259   142267       +8     
  Branches      17082    17085       +3     
============================================
- Hits         103724   103712      -12     
- Misses        30314    30324      +10     
- Partials       8221     8231      +10     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.91% <ø> (-0.14%) 492.00 <0.00> (-1.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.34% <100.00%> (+0.11%) 1195.00 <0.00> (+4.00)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 88.33% <0.00%> (-1.67%) 28.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 60.37% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
... and 4 more

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@ratulm ratulm merged commit 00c74bd into master Oct 1, 2020
@ratulm ratulm deleted the eigrp-distlist-refs branch October 1, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco IOS EIGRP distribute-list not recognized
3 participants