New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing for prefix and route-map in EIGRP distribute-list #6271
Conversation
projects/batfish/src/main/java/org/batfish/grammar/cisco/CiscoControlPlaneExtractor.java, line 7706 at r1 (raw file): Quoted 5 lines of code…
is there a reason you're not using |
Codecov Report
@@ Coverage Diff @@
## master #6271 +/- ##
============================================
- Coverage 72.91% 72.90% -0.01%
Complexity 35015 35015
============================================
Files 2832 2832
Lines 142275 142311 +36
Branches 17085 17090 +5
============================================
+ Hits 103741 103756 +15
- Misses 30313 30325 +12
- Partials 8221 8230 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)
projects/batfish/src/main/java/org/batfish/grammar/cisco/CiscoControlPlaneExtractor.java, line 7706 at r1 (raw file):
Previously, dhalperi (Dan Halperin) wrote…
dWarning( ctx, getFullText(ctx.getParent()), _parser, "Prefi
is there a reason you're not using
todo
? It takes an optional message.
good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Fixes #6237