Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing for prefix and route-map in EIGRP distribute-list #6271

Merged
merged 2 commits into from Oct 2, 2020

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Oct 1, 2020

Fixes #6237

@batfish-bot
Copy link

This change is Reviewable

@dhalperi
Copy link
Member

dhalperi commented Oct 1, 2020


projects/batfish/src/main/java/org/batfish/grammar/cisco/CiscoControlPlaneExtractor.java, line 7706 at r1 (raw file):

Quoted 5 lines of code…
dWarning(
        ctx,
        getFullText(ctx.getParent()),
        _parser,
        "Prefi

is there a reason you're not using todo? It takes an optional message.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #6271 into master will decrease coverage by 0.00%.
The diff coverage is 77.50%.

@@             Coverage Diff              @@
##             master    #6271      +/-   ##
============================================
- Coverage     72.91%   72.90%   -0.01%     
  Complexity    35015    35015              
============================================
  Files          2832     2832              
  Lines        142275   142311      +36     
  Branches      17085    17090       +5     
============================================
+ Hits         103741   103756      +15     
- Misses        30313    30325      +12     
- Partials       8221     8230       +9     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.87% <ø> (-0.14%) 492.00 <0.00> (-1.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.38% <73.52%> (+0.02%) 1204.00 <8.00> (+8.00)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 88.33% <0.00%> (-1.67%) 28.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.47% <0.00%> (-0.33%) 208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 76.00% <0.00%> (-0.16%) 246.00% <0.00%> (-1.00%)

Copy link
Member Author

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)


projects/batfish/src/main/java/org/batfish/grammar/cisco/CiscoControlPlaneExtractor.java, line 7706 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…
dWarning(
        ctx,
        getFullText(ctx.getParent()),
        _parser,
        "Prefi

is there a reason you're not using todo? It takes an optional message.

good idea

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@ratulm ratulm merged commit e86f801 into master Oct 2, 2020
@ratulm ratulm deleted the more-eigrp-dl branch October 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco IOS EIGRP distribute-list not recognized
3 participants