Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP ribs: do not merge routes with unreachable next hops #6274

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

progwriter
Copy link
Contributor

Because that's how BGP actually works.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #6274 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6274      +/-   ##
============================================
- Coverage     72.91%   72.90%   -0.01%     
- Complexity    35015    35026      +11     
============================================
  Files          2832     2832              
  Lines        142275   142324      +49     
  Branches      17085    17094       +9     
============================================
+ Hits         103741   103766      +25     
- Misses        30313    30328      +15     
- Partials       8221     8230       +9     
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/batfish/dataplane/rib/Bgpv4Rib.java 100.00% <100.00%> (ø) 7.00 <6.00> (+6.00)
...main/java/org/batfish/datamodel/PrefixIpSpace.java 87.50% <0.00%> (-5.84%) 8.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 88.33% <0.00%> (-1.67%) 28.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.47% <0.00%> (-0.33%) 208.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.85% <0.00%> (-0.32%) 246.00% <0.00%> (-1.00%)
...tfish/representation/cisco/CiscoConfiguration.java 85.87% <0.00%> (-0.14%) 492.00% <0.00%> (-1.00%)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
... and 7 more

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit f3a28f2 into batfish:master Oct 5, 2020
@progwriter progwriter deleted the bgp-check-reach branch October 5, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants