Parse eigrp stub

[ratulm]

Fixes #6236

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6275 into master will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #6275      +/-   ##
============================================
- Coverage     72.92%   72.90%   -0.02%     
+ Complexity    35028    35021       -7     
============================================
  Files          2832     2832              
  Lines        142317   142326       +9     
  Branches      17090    17090              
============================================
- Hits         103782   103763      -19     
- Misses        30311    30330      +19     
- Partials       8224     8233       +9     

Impacted Files	Coverage Δ	Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java	85.87% <ø> (-0.14%)	492.00 <0.00> (-1.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java	65.36% <69.23%> (-0.03%)	1206.00 <2.00> (+2.00)	⬇️
...fish/representation/cisco/CiscoStructureUsage.java	100.00% <100.00%> (ø)	3.00 <0.00> (ø)
...rg/batfish/identifiers/StorageBasedIdResolver.java	85.29% <0.00%> (-5.89%)	22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java	83.67% <0.00%> (-4.09%)	18.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java	88.33% <0.00%> (-1.67%)	28.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	89.54% <0.00%> (-1.37%)	50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	59.25% <0.00%> (-1.24%)	15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java	86.42% <0.00%> (-0.95%)	250.00% <0.00%> (ø%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	90.47% <0.00%> (-0.33%)	208.00% <0.00%> (-1.00%)
... and 3 more

[dhalperi]

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @ratulm)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/Cisco_eigrp.g4, line 175 at r1 (raw file):

;

re_eigrp_stub

not a blocker, but better to write like an LL1 parser:

• create re_eigrp
• (really opt: move re_rigrp_null inside of it, dropping the no?)
• create re_eigrp_stub (or ree_stub?)
• create rees_null and rees_leak_map

and only do the leak_map handling inside of leak_map.

This both makes the parser more efficient, the grammar easier to read, and the extraction code simpler

[ratulm]

Reviewable status: 5 of 8 files reviewed, all discussions resolved (waiting on @arifogel and @dhalperi)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/Cisco_eigrp.g4, line 175 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

not a blocker, but better to write like an LL1 parser:

• create re_eigrp
• (really opt: move re_rigrp_null inside of it, dropping the no?)
• create re_eigrp_stub (or ree_stub?)
• create rees_null and rees_leak_map

and only do the leak_map handling inside of leak_map.

This both makes the parser more efficient, the grammar easier to read, and the extraction code simpler

done. left re_eigrp_router_id alone as its leading 'no' is being processed in the extractor.

[dhalperi]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)